Skip to content

Comments

Japanese translation added#343

Merged
GyulyVGC merged 4 commits intoGyulyVGC:mainfrom
hirotake111:feature-japanese-translation
Aug 18, 2023
Merged

Japanese translation added#343
GyulyVGC merged 4 commits intoGyulyVGC:mainfrom
hirotake111:feature-japanese-translation

Conversation

@hirotake111
Copy link
Contributor

This is a PR to add Japanese to a language option as requested in issue #60.

As @GyulyVGC mentioned here it needs additional font files to be able to display the Japanese language on Sniffnet as expected. Please proceed.

If you have any questions, feel free to contact me anytime 😄

@GyulyVGC GyulyVGC added this to the v1.3.0 milestone Aug 15, 2023
@GyulyVGC GyulyVGC added the translation User interface translation label Aug 15, 2023
@GyulyVGC
Copy link
Owner

I've added the Japanese glyphs.
Please let me know if everything is displayed as it's supposed to be.

I've also noticed that some sentences are missing in the file translation_2.rs... could you add them? (If they are supposed to be equal to English add them to the English arm of the match clause, otherwise please add a new arm).

@hirotake111
Copy link
Contributor Author

@GyulyVGC

Please let me know if everything is displayed as it's supposed to be.

Thanks for your support. I looked at it and everything looks good now.
(I fixed some words as those sound weird.)

As you requested, I also filled in some missing parts in translation_2.rs 😄

@GyulyVGC
Copy link
Owner

I'm happy that Sniffnet finally has a Japanese translation, the last popular language among the app users that was still missing 🎉

Thank you very much!

@GyulyVGC GyulyVGC merged commit df7507b into GyulyVGC:main Aug 18, 2023
@GyulyVGC
Copy link
Owner

@all-contributors please add @hirotake111 for translation.

@allcontributors
Copy link
Contributor

@GyulyVGC

I've put up a pull request to add @hirotake111! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translation User interface translation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants