Skip to content

Comments

fix build failure on powerpc64#356

Merged
GyulyVGC merged 1 commit intoGyulyVGC:mainfrom
dutyrok:main
Aug 27, 2023
Merged

fix build failure on powerpc64#356
GyulyVGC merged 1 commit intoGyulyVGC:mainfrom
dutyrok:main

Conversation

@dutyrok
Copy link
Contributor

@dutyrok dutyrok commented Aug 26, 2023

Disable rustls-tls features of reqwest dependency for ppc64 because of ruslts needs ring, which the latest stable version doesn't support this arch.

Disable rustls-tls features of reqwest dependency for ppc64 because of ruslts
needs ring, which the latest stable version doesn't support this arch.
@dutyrok dutyrok changed the title fix build failure on powerpc64 that closes #353 fix build failure on powerpc64 that closes Aug 26, 2023
@dutyrok dutyrok changed the title fix build failure on powerpc64 that closes fix build failure on powerpc64 Aug 26, 2023
@GyulyVGC GyulyVGC linked an issue Aug 27, 2023 that may be closed by this pull request
1 task
@GyulyVGC GyulyVGC added the dependencies Pull requests that update a dependency file label Aug 27, 2023
@GyulyVGC
Copy link
Owner

So, this cargo.lock is built on a target architecture different from powerpc64 and we should keep this version on the repo.

Did you try building it also on powerpc64 as a confirmation? Is everything fine?

@GyulyVGC GyulyVGC added this to the v1.3.0 milestone Aug 27, 2023
@GyulyVGC GyulyVGC merged commit e2d5bd5 into GyulyVGC:main Aug 27, 2023
@GyulyVGC
Copy link
Owner

@all-contributors please add @dutyrok for bug.

@allcontributors
Copy link
Contributor

@GyulyVGC

I've put up a pull request to add @dutyrok! 🎉

@dutyrok
Copy link
Contributor Author

dutyrok commented Aug 27, 2023

Did you try building it also on powerpc64 as a confirmation? Is everything fine?

Yes, sniffnet has been built on this arch and works (at least in qemu). I put a build log as a proof of build is success.
sniffnet-1.2.2-ppc64.log

@GyulyVGC GyulyVGC added the bug Something isn't working label Aug 27, 2023
@GyulyVGC
Copy link
Owner

Hey @dutyrok reqwest was updated today and now uses rustls by default, which now depends on ring 0.17 that added support for powerpc64.

For this reason, I've just updated the reqwest dependency to use rustls also on powerpc64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure for ppc64

2 participants