Merged
Conversation
…ader is not lazy anymore
This was referenced Feb 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR finally adds a proper tabular structure for connections in inspect page (until now, the table columns were kept aligned using a determined amount of whitespaces).
This fixes #63: the new table structure will remain aligned for every possible field value length.
Moreover, new search filters have been introduced (one for each table column) so that it's possible for users to accurately filter connections according to several parameters: source and destination IP, source and destination port, and protocols, in addition to the previously available search filters.
Note that by default, for ease of use, search filters check for partial matches; if you want strict equality, just add '=' before the desired filter value.
Finally, now it's possible to sort the table also for ascending value of bytes and packets, in addition to the already existing sorting strategy (by default, it's still sorted by most recent).
Note how longer values (in this case in the table header) don't cause the table to be dealigned; hovering on them will show the full value.