Skip to content

Comments

Support more upper layer services (many, many, many more)#450

Merged
GyulyVGC merged 22 commits intomainfrom
services-phf
Feb 11, 2024
Merged

Support more upper layer services (many, many, many more)#450
GyulyVGC merged 22 commits intomainfrom
services-phf

Conversation

@GyulyVGC
Copy link
Owner

@GyulyVGC GyulyVGC commented Feb 6, 2024

Note

This PR replaces the original #446


As requested in #374 and by multiple other users of the application (e.g., #289, #338), this PR adds support for several new upper layer services in addition to the 24 already supported application layer protocols.

The full list of the new supported services, taken from Nmap, is basically the IANA assigned ports list plus some trojans and worms.
It contains 6438 different services/protocols/trojans/worms.

Services are stored as a compile-time, static, perfect hash map generated in build.rs with the help of rust-phf.
This strategy guarantees high performances while avoiding the complexities of #446.

Fixes #374

@GyulyVGC GyulyVGC added the enhancement New feature, request, or improvement label Feb 6, 2024
@GyulyVGC GyulyVGC added this to the v1.3.0 milestone Feb 6, 2024
@GyulyVGC GyulyVGC self-assigned this Feb 6, 2024
@GyulyVGC GyulyVGC marked this pull request as draft February 6, 2024 23:48
Copy link
Owner Author

@GyulyVGC GyulyVGC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@GyulyVGC GyulyVGC marked this pull request as ready for review February 10, 2024 14:50
@GyulyVGC GyulyVGC merged commit 5a62933 into main Feb 11, 2024
@GyulyVGC GyulyVGC deleted the services-phf branch February 11, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, request, or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request] More Port/Application Info

1 participant