Improve update check with semver#891
Merged
GyulyVGC merged 9 commits intoGyulyVGC:mainfrom Sep 18, 2025
Merged
Conversation
Owner
|
Thanks, awesome! It'd be amazing if you could add some tests to assert that it behaves as expected trying with different version numbers |
Owner
|
Nevermind I read the specs at https://docs.rs/semver/1.0.26/semver/struct.Version.html#total-ordering And given that the library is maintained by dtolnay, I trust it 😅 |
Contributor
Author
|
Hahahah, I agree i should have added some but i mean semver seems very reliable. |
Contributor
Author
|
Oops, completely forgot about that |
Contributor
Author
|
That's it ! |
aguacero7
force-pushed
the
improve-versionning
branch
from
5bcf252 to
6a5b12e
Compare
Contributor
Author
|
Finally ahah |
Owner
|
Thanks! |
Owner
|
@all-contributors please add @aguacero7 for code. |
Contributor
|
I've put up a pull request to add @aguacero7! 🎉 |
GyulyVGC
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.