Skip to content

Take advantage of simplified logging#366

Merged
mambelli merged 2 commits intoHEPCloud:masterfrom
knoepfel:simplified-logging
Sep 30, 2021
Merged

Take advantage of simplified logging#366
mambelli merged 2 commits intoHEPCloud:masterfrom
knoepfel:simplified-logging

Conversation

@knoepfel
Copy link
Contributor

@pep8speaks
Copy link

pep8speaks commented Sep 21, 2021

Hello @knoepfel! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-09-27 16:22:23 UTC

@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #366 (127bdfc) into master (f4752ab) will decrease coverage by 1.04%.
The diff coverage is 43.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #366      +/-   ##
==========================================
- Coverage   37.30%   36.26%   -1.05%     
==========================================
  Files          80       80              
  Lines        3522     3444      -78     
  Branches      565      576      +11     
==========================================
- Hits         1314     1249      -65     
+ Misses       2118     2104      -14     
- Partials       90       91       +1     
Flag Coverage Δ
python-3.6 36.16% <43.28%> (-1.05%) ⬇️
python-3.9 36.26% <43.28%> (-1.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...gine_modules/AWS/publishers/AWS_figure_of_merit.py 57.14% <ø> (-2.86%) ⬇️
...ne_modules/AWS/publishers/AWS_generic_publisher.py 77.14% <0.00%> (-0.64%) ⬇️
...ne_modules/AWS/publishers/AWS_price_performance.py 60.00% <ø> (-2.50%) ⬇️
...gine_modules/AWS/sources/AWSInstancePerformance.py 100.00% <ø> (ø)
...decisionengine_modules/AWS/sources/AWSJobLimits.py 86.95% <ø> (-0.55%) ⬇️
...decisionengine_modules/AWS/sources/AWSOccupancy.py 0.00% <0.00%> (ø)
...modules/AWS/sources/AWSOccupancyWithSourceProxy.py 69.69% <ø> (-0.46%) ⬇️
...decisionengine_modules/AWS/sources/AWSSpotPrice.py 0.00% <0.00%> (ø)
.../decisionengine_modules/AWS/sources/BillingInfo.py 0.00% <ø> (ø)
...nengine_modules/AWS/sources/FinancialParameters.py 0.00% <ø> (ø)
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4752ab...127bdfc. Read the comment docs.

@jcpunk
Copy link
Collaborator

jcpunk commented Sep 21, 2021

Can you rebase off HEAD?

jcpunk
jcpunk previously approved these changes Sep 22, 2021
@BrunoCoimbra
Copy link
Contributor

Can we also use the new logging boilerplate model for Sources and Publishers as well?
e.g.: FactoryClientManifests and JobClusteringPublisher

@knoepfel
Copy link
Contributor Author

Good catch, @BrunoCoimbra. I'll update the PR.

@knoepfel
Copy link
Contributor Author

@BrunoCoimbra, I adjusted the logging according to your suggestions. I also adjusted various utility functions so that a logger is "passed in" to the function if logging is desired--this way, we associate the messages from the utility function with the module that uses that utility.

@knoepfel knoepfel force-pushed the simplified-logging branch 2 times, most recently from 9a7fa1c to cf03f1c Compare September 27, 2021 15:06
@knoepfel knoepfel requested a review from jcpunk September 27, 2021 15:16
Includes removing bare logging usage in utility functions--loggers are
"passed in" to the functions if logging is desired.
@mambelli mambelli merged commit ee7d45c into HEPCloud:master Sep 30, 2021
@knoepfel knoepfel deleted the simplified-logging branch September 30, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants