Skip to content

Homogenize parameter-naming for retries#372

Merged
mambelli merged 1 commit intoHEPCloud:masterfrom
knoepfel:parameter-naming
Oct 1, 2021
Merged

Homogenize parameter-naming for retries#372
mambelli merged 1 commit intoHEPCloud:masterfrom
knoepfel:parameter-naming

Conversation

@knoepfel
Copy link
Contributor

This PR fixes #253. It includes the following changes:

  • For source proxy: retries -> max_attempts, retry_timeout -> retry_interval
  • Otherwise, nretries -> max_retries

@knoepfel knoepfel changed the title Homogenize parameter-naming. Homogenize parameter-naming for retries Sep 30, 2021
Includes the following changes:

- For source proxy: retries -> max_attempts, retry_timeout -> retry_interval
- Otherwise, nretries -> max_retries
@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #372 (0dbfb9b) into master (ee7d45c) will not change coverage.
The diff coverage is 92.30%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #372   +/-   ##
=======================================
  Coverage   36.26%   36.26%           
=======================================
  Files          80       80           
  Lines        3444     3444           
  Branches      576      576           
=======================================
  Hits         1249     1249           
  Misses       2104     2104           
  Partials       91       91           
Flag Coverage Δ
python-3.6 36.16% <92.30%> (ø)
python-3.9 36.26% <92.30%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...modules/AWS/sources/AWSOccupancyWithSourceProxy.py 69.69% <ø> (ø)
...modules/AWS/sources/AWSSpotPriceWithSourceProxy.py 69.89% <ø> (ø)
...ngine_modules/NERSC/sources/NerscAllocationInfo.py 85.00% <ø> (ø)
...cisionengine_modules/NERSC/sources/NerscJobInfo.py 83.33% <ø> (ø)
src/decisionengine_modules/util/retry_function.py 65.51% <80.00%> (ø)
src/decisionengine_modules/NERSC/util/newt.py 34.28% <100.00%> (ø)
...gine_modules/glideinwms/sources/factory_entries.py 86.53% <100.00%> (ø)
...ngine_modules/glideinwms/sources/factory_global.py 77.27% <100.00%> (ø)
...ionengine_modules/htcondor/publishers/publisher.py 44.76% <100.00%> (ø)
...decisionengine_modules/util/test_retry_function.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee7d45c...0dbfb9b. Read the comment docs.

@HEPCloud HEPCloud deleted a comment from lgtm-com bot Sep 30, 2021
@mambelli mambelli merged commit 63f6315 into HEPCloud:master Oct 1, 2021
@knoepfel knoepfel deleted the parameter-naming branch January 18, 2022 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Different modules are using different retry parameters in config

2 participants