One monolithic factory-entries data product

[knoepfel]

Instead of one data product for each factory entry type, this PR merges all of those products into a monolithic data product called "Factory_Entries".

[codecov]

Codecov Report

Base: 47.41% // Head: 47.36% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (8f95d49) compared to base (f2057d1).
Patch coverage: 94.73% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #429      +/-   ##
==========================================
- Coverage   47.41%   47.36%   -0.06%     
==========================================
  Files          54       54              
  Lines        2902     2903       +1     
  Branches      523      523              
==========================================
- Hits         1376     1375       -1     
- Misses       1426     1427       +1     
- Partials      100      101       +1     

Flag	Coverage Δ
python-3.6	47.27% <94.73%> (-0.06%)	⬇️
python-3.9	47.36% <94.73%> (-0.06%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...modules/glideinwms/publishers/fe_group_classads.py	89.09% <88.88%> (-3.22%)	⬇️
...nengine_modules/GCE/transforms/GceFigureOfMerit.py	87.17% <100.00%> (ø)
...ine_modules/NERSC/transforms/NerscFigureOfMerit.py	100.00% <100.00%> (ø)
...gine_modules/glideinwms/sources/factory_entries.py	86.00% <100.00%> (-0.54%)	⬇️
...ules/glideinwms/transforms/grid_figure_of_merit.py	89.65% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[StevenCTimm]

Should also check glideinwms/glide_frontend_element.py to make sure there's nothing in there. Otherwise this looks good.

[shreyb]

Not a blocker, but is it fairly trivial to add a test to make sure that if the glideclient_manifests data block is empty, we get an empty pandas.DataFrame()?

[knoepfel]

Yes, I'll find a way to cover this.

[shreyb]

Approved, but I had one comment to see if it's possible to increase coverage for the lines added in fe_group_classads.py.

[shreyb]

Looks good. Thanks!