Add initial Rigetti source#435
Merged
mambelli merged 1 commit intoHEPCloud:masterfrom Sep 20, 2022
jcpunk:rigetti-source
Merged
Add initial Rigetti source#435mambelli merged 1 commit intoHEPCloud:masterfrom jcpunk:rigetti-source
mambelli merged 1 commit intoHEPCloud:masterfrom
jcpunk:rigetti-source
Conversation
Collaborator
Author
|
@StevenCTimm Thoughts? |
Codecov ReportBase: 47.41% // Head: 47.43% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #435 +/- ##
==========================================
+ Coverage 47.41% 47.43% +0.01%
==========================================
Files 54 54
Lines 2902 2901 -1
Branches 523 522 -1
==========================================
Hits 1376 1376
+ Misses 1426 1425 -1
Partials 100 100
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mambelli
requested changes
Sep 15, 2022
Contributor
mambelli
left a comment
mambelli
left a comment
There was a problem hiding this comment.
Functionality seems OK but I'm not familiar w/ the API and I don't have a way to test/verify. Comments are just on the code
src/decisionengine_modules/Rigetti/sources/Rigetti_BillingInfo.py
Outdated
Show resolved
Hide resolved
mambelli
approved these changes
Sep 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provides initial data on credits at the Rigetti computers.
This cannot currently be unit tested.