Skip to content

Fix de_client call#436

Merged
mambelli merged 1 commit intoHEPCloud:masterfrom
vitodb:vito_fix_de_client_call
Sep 8, 2022
Merged

Fix de_client call#436
mambelli merged 1 commit intoHEPCloud:masterfrom
vitodb:vito_fix_de_client_call

Conversation

@vitodb
Copy link
Contributor

@vitodb vitodb commented Sep 7, 2022

This is required to allow de_client to get its output returned as text string rather then using a logger.
This fixes an issue when using decisionengine_modules/glideinwms/configure_gwms_frontend.py to generate GWMS configuration from glideinwms.libsonnet
Thanks to Kyle for the help to get the issue fixed.

This is required to allow de_client to get its output returned as text string rather then using a logger.
@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Base: 47.41% // Head: 47.41% // No change to project coverage 👍

Coverage data is based on head (a6744f1) compared to base (f2057d1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #436   +/-   ##
=======================================
  Coverage   47.41%   47.41%           
=======================================
  Files          54       54           
  Lines        2902     2902           
  Branches      523      523           
=======================================
  Hits         1376     1376           
  Misses       1426     1426           
  Partials      100      100           
Flag Coverage Δ
python-3.6 ?
python-3.9 47.41% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ecisionengine_modules/glideinwms/DEConfigSource.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mambelli mambelli merged commit cc6b01a into HEPCloud:master Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants