Merged
Conversation
This is required to allow de_client to get its output returned as text string rather then using a logger.
Codecov ReportBase: 47.41% // Head: 47.41% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #436 +/- ##
=======================================
Coverage 47.41% 47.41%
=======================================
Files 54 54
Lines 2902 2902
Branches 523 523
=======================================
Hits 1376 1376
Misses 1426 1426
Partials 100 100
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
knoepfel
approved these changes
Sep 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required to allow de_client to get its output returned as text string rather then using a logger.
This fixes an issue when using
decisionengine_modules/glideinwms/configure_gwms_frontend.pyto generate GWMS configuration fromglideinwms.libsonnetThanks to Kyle for the help to get the issue fixed.