Change glideclient advertisement logic#484
Merged
mambelli merged 1 commit intoHEPCloud:masterfrom Dec 14, 2023
Merged
Conversation
BrunoCoimbra
force-pushed
the
issue-446
branch
from
c663b82 to
2a8fcb0
Compare
StevenCTimm
reviewed
Dec 8, 2023
Contributor
StevenCTimm
left a comment
StevenCTimm
left a comment
There was a problem hiding this comment.
From my knowledge of the code system it appears that this will have the intended effect and solve the problem in !446
I leave the review of the actual mechanics of the code to others.
BrunoCoimbra
force-pushed
the
issue-446
branch
from
2a8fcb0 to
241a4bb
Compare
|
Hello @BrunoCoimbra! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
mambelli
approved these changes
Dec 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the
glideclientclassads advertisement logic to address #446.Now, the GlideinWMS module of Decision Engine will keep refreshing
glideclients while Glideins associated with them are present.