Skip to content

Add CI, test suite, team templates, and fix config bugs#1

Merged
tjb-tech merged 3 commits intoHKUDS:mainfrom
he-yufeng:feat/ci-tests-templates
Mar 18, 2026
Merged

Add CI, test suite, team templates, and fix config bugs#1
tjb-tech merged 3 commits intoHKUDS:mainfrom
he-yufeng:feat/ci-tests-templates

Conversation

@he-yufeng
Copy link
Copy Markdown
Contributor

Summary

This PR adds foundational quality infrastructure and new features to ClawTeam:

Test Suite (112 tests, 0.3s)

  • test_config.py — config load/save roundtrip, get_effective env/file/default priority
  • test_models.py — Pydantic model defaults, alias serialization, JSON roundtrips
  • test_tasks.py — TaskStore CRUD, dependency resolution, task locking and dead-agent release
  • test_mailbox.py — send/receive/broadcast, consume semantics, peek, event logging
  • test_manager.py — team create/cleanup, member management, leader lookup
  • test_templates.py — variable substitution, builtin template validation, user override

All tests use tmp_path with CLAWTEAM_DATA_DIR isolation — no filesystem side effects.

CI (GitHub Actions)

  • Ruff lint + pytest across Python 3.10/3.11/3.12 on ubuntu + macos

New Team Templates

  • code-review — multi-perspective code review (security, performance, architecture reviewers)
  • research-paper — academic research team (PI, lit survey, methodology, data analysis)

Bug Fixes

  • config show only displayed 3 of 7 config keys — now shows all
  • get_effective used truthiness check (if file_val:), so skip_permissions=False would fall through to default True — now compares against default value instead
  • config show display: boolean values rendered properly with str() instead of or "(empty)"

Test plan

  • pytest tests/ -v — 112 passed in 0.32s
  • ruff check tests/ — all checks passed
  • CI workflow validates on push

CI:
- GitHub Actions workflow: ruff lint + pytest on Python 3.10/3.11/3.12
  across ubuntu and macos

Templates:
- code-review: multi-perspective review team (security, performance,
  architecture reviewers coordinated by a lead)
- research-paper: academic research team (PI, literature surveyor,
  methodology designer, data analyst)

Bug fixes:
- config show: display all 7 config keys instead of only 3
- get_effective: compare against default instead of checking truthiness,
  so explicitly-set falsy values (like skip_permissions=False) aren't
  silently replaced by defaults
- config show: handle boolean values in display (str() instead of or)
@he-yufeng
Copy link
Copy Markdown
Contributor Author

@tjb-tech

@tjb-tech tjb-tech merged commit a46ab24 into HKUDS:main Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants