fix(heartbeat): preserve HEARTBEAT.md details in phase-2 execution#1359
Closed
KimGLee wants to merge 3 commits into
Closed
fix(heartbeat): preserve HEARTBEAT.md details in phase-2 execution#1359KimGLee wants to merge 3 commits into
KimGLee wants to merge 3 commits into
Conversation
KimGLee
force-pushed
the
fix/heartbeat-preserve-details
branch
from
b3a74f0 to
3b51bab
Compare
KimGLee
force-pushed
the
fix/heartbeat-preserve-details
branch
2 times, most recently
from
9d792ed to
0aa0a8f
Compare
KimGLee
force-pushed
the
fix/heartbeat-preserve-details
branch
from
ed7ebb5 to
bec1f90
Compare
Contributor
Author
|
Closing this PR because, after extended inactivity, it no longer appears to fit the current project direction and merge trajectory. If this area becomes important again, it would be better to revisit it against the latest main baseline with a fresh proposal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1310.
Why
The current two-phase heartbeat flow decides on a summarized
tasksstring in phase-1, then executes only that summary in phase-2. This can drop important details from HEARTBEAT.md and reduce task quality.Changes
nanobot/heartbeat/service.py_build_execution_input(tasks, content)helper_tick()andtrigger_now(), pass merged execution input (summary + full heartbeat details) toon_executeNotes