Merged
Conversation
- Unskip matrix logic by adding missing deps (matrix-nio, nh3, mistune) - Update matrix tests for 'allow_from' default deny security change - Fix asyncio typing keepalive leak in matrix tests - Update context prompt cache assert after runtime message merge - Fix flaky cron service test with mtime sleep - Remove obsolete test_cron_commands.py testing deleted CLI commands
…ebsockets DeprecationWarnings
Contributor
Author
|
Updated with main branch |
Collaborator
|
Thanks for putting this together! 🙌 Quick note: since PR #1521 was already merged into main before this PR was created, you can simply rebase onto the latest main branch. The changes from #1521 are already there, so no need to add me as a co-author — the git history will preserve the attribution automatically. Once rebed, the diff should only contain your new fixes (dependencies, feishu lazy import, SafeCommandPolicy updates, etc.). Appreciate the effort to fix the failing tests! |
Closed
robottwo
pushed a commit
to robottwo/nanobot
that referenced
this pull request
Mar 13, 2026
fix(tests): resolve failing tests
sorker
pushed a commit
to sorker/nanobot
that referenced
this pull request
Mar 24, 2026
fix(tests): resolve failing tests
Wattysaid
pushed a commit
to kieran-assistant/nanobot
that referenced
this pull request
Apr 3, 2026
fix(tests): resolve failing tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Draft: Fix Failing Tests & Warnings
Summary
This PR resolves all currently failing tests on the main branch and fixes missing production dependencies required for fresh environments. It integrates overlapping work from PR #1521.
Changes
Dependency
pyproject.toml:matrix-nioandnh3to production requirements (fixeduv syncimport errors).chardet>=3.0.2,<6.0.0to resolve transitive version conflict betweenreadability-lxmlandrequests.Feishu channel
feishu.py:Security
nanobot/agent/tools/security.py:catand ls to the defaultSafeCommandPolicyto allow basic filesystem tool-use in tests.Agent loop test
tests/test_agent_loop.py:Integrated PR test: fix test failures from refactored cron and context builder #1521 (Credit to @chengyongru):
Cron test
tests/test_cron.py:Motivation
The main branch is currently unstable due to some broken tests, missing dependencies and some minor warnings. These changes restore 100% test passing rate and improve CI reliability.
Verification
Tested in a clean
uvenvironment with all 148 tests passing:uv syncsuccessfully installs all required packages for Matrix and Telegram channels.catand ls now work in the default agent shell without policy violations.asynciono longer reports leaked tasks after test completion.Co-authored-by: @chengyongru