fix: advance last_consolidated on consolidation failure to prevent re…#1691
Open
TTdogCC wants to merge 1 commit intoHKUDS:mainfrom
Open
fix: advance last_consolidated on consolidation failure to prevent re…#1691TTdogCC wants to merge 1 commit intoHKUDS:mainfrom
TTdogCC wants to merge 1 commit intoHKUDS:mainfrom
Conversation
This was referenced Mar 8, 2026
…try storm When memory consolidation fails (LLM timeout or error), last_consolidated was not updated, causing the next trigger to retry an ever-growing batch. This leads to unbounded message accumulation and cascading LLM timeouts. Fixes HKUDS#1174
db18fe4 to
ed9d752
Compare
This was referenced Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…try storm
Root cause analysis of
loop.py/memory.py:When memory consolidation fails (LLM timeout or error),
last_consolidatedwas not updated, causing the next trigger to retry an ever-growing batch. This leads to unbounded message accumulation and cascading LLM timeouts.Specifically:
last_consolidatedis only updated on success — if the LLM call fails, it stays at the old positionlen(session.messages) > self.memory_windowkeeps firing every message once exceededFix: In the
exceptblock of_consolidate_memory, advancelast_consolidatedto the current position even on failure, matching the success-path logic. Theif not archive_allguard ensures the/newcommand path is unaffected.Note: concurrency guards (
self._consolidatingset + task lock) were already in place inloop.py.Fixes #1174