ToolRegistry.register() silently overwrites tools with the same name.#1747
Open
pixan-ai wants to merge 1 commit intoHKUDS:mainfrom
Open
ToolRegistry.register() silently overwrites tools with the same name.#1747pixan-ai wants to merge 1 commit intoHKUDS:mainfrom
pixan-ai wants to merge 1 commit intoHKUDS:mainfrom
Conversation
This can happen when multiple MCP servers expose tools with identical names, causing one to disappear without any indication. Adds a logger.warning() so users can diagnose unexpected tool conflicts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can happen when multiple MCP servers expose tools with identical names, causing one to disappear without any indication.
Adds a logger.warning() so users can diagnose unexpected tool conflicts.
What
Add a warning log when registering a tool that overwrites an existing one.
Why
ToolRegistry.register()silently overwrites if a tool with the samename already exists. This can happen when multiple MCP servers expose
tools with identical names — one tool quietly disappears with no
indication to the user, making debugging very difficult.
How
tool.namealready exists in the registry before overwritingloguru.loggerTesting
Acknowledgment
Fix identified and developed with assistance from Claude Opus 4.6