fix(memory): pass agent generation settings to consolidation#1825
Closed
IsamAlBalushi wants to merge 3 commits intoHKUDS:mainfrom
Closed
fix(memory): pass agent generation settings to consolidation#1825IsamAlBalushi wants to merge 3 commits intoHKUDS:mainfrom
IsamAlBalushi wants to merge 3 commits intoHKUDS:mainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 976be443f2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This was referenced Mar 11, 2026
Author
|
Looks like this was resolved by commit b957dbc which moved generation settings I confirmed locally that memory consolidation now sends the correct |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This passes the active agent generation settings through the memory consolidation path so consolidation uses the same
temperature,max_tokens, andreasoning_effortas the main agent loop.Problem
AgentLoop._consolidate_memory()callsMemoryStore.consolidate()without forwarding these settings. As a result, the provider falls back to default values during consolidation.Fix
temperature,max_tokens, andreasoning_effortparams toMemoryStore.consolidate()AgentLoop._consolidate_memory()provider.chat_with_retry(...)Fixes #1823
Notes
This is a minimal change and keeps existing behavior unchanged outside the memory consolidation path.