fix: preserve interactive CLI formatting for async subagent output#1930
Merged
Re-bin merged 1 commit intoHKUDS:mainfrom Mar 12, 2026
Merged
fix: preserve interactive CLI formatting for async subagent output#1930Re-bin merged 1 commit intoHKUDS:mainfrom
Re-bin merged 1 commit intoHKUDS:mainfrom
Conversation
Collaborator
|
Hi @ducheng121 Thanks for your working! |
Re-bin
added a commit
that referenced
this pull request
Mar 12, 2026
This was referenced Mar 13, 2026
sorker
pushed a commit
to sorker/nanobot
that referenced
this pull request
Mar 24, 2026
Wattysaid
pushed a commit
to kieran-assistant/nanobot
that referenced
this pull request
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1904
Summary
Fix interactive CLI output corruption when async subagent completion messages arrive while the user is typing.
Cause
The CLI used
prompt_toolkitfor interactive input, but async outbound messages were rendered by Rich directly to the terminal. This could corrupt the prompt and leak ANSI control sequences like?[36m...?[0m.Fix
prompt_toolkitsafe terminal output instead of writing directly to stdoutVerification
Manually tested: