fix(providers): add max_completion_tokens for openai o1 compatibility#2464
Merged
chengyongru merged 1 commit intoHKUDS:nightlyfrom Mar 25, 2026
Merged
Conversation
Collaborator
|
Thanks for your work! Could you make a PR 2 main branch? |
This was referenced Mar 25, 2026
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2462
What
Adds
max_completion_tokensalongsidemax_tokensin theopenai_compat_providerpayload.Why
OpenAI deprecated
max_tokensin favor ofmax_completion_tokensstarting with theo1model series to separate the limit for final output tokens from the new "reasoning tokens". When usingo1models via OpenAI-compatible endpoints, passing onlymax_tokensresults in anunsupported_parametererror.How it works
We now send both
max_tokensandmax_completion_tokenswith the same value. This ensures compatibility with newer endpoints that requiremax_completion_tokens(like OpenAI'so1models or recent vLLM/Ollama versions) while maintaining backward compatibility with older local servers that might strictly validate the payload and reject unknown parameters.