fix(discord): remove duplicate channel_id assignment in message handler#3178
Merged
Re-bin merged 1 commit intoHKUDS:mainfrom Apr 15, 2026
Merged
Conversation
channel_id is already assigned from self._channel_key(message.channel) earlier in the same function. The second identical assignment on line 453 is dead code left over from a copy-paste.
Contributor
Author
|
@Re-bin Could you take a look? Thanks:) |
Re-bin
approved these changes
Apr 15, 2026
Collaborator
Re-bin
left a comment
Re-bin
left a comment
There was a problem hiding this comment.
This is the right kind of fix.
The intent is narrow, the boundary is clear, and the implementation removes a real copy-paste leftover without changing behavior.
channel_id is already computed earlier in _handle_discord_message() and nothing mutates message.channel in between, so the second assignment is genuinely dead code.
I pulled the branch locally, checked the origin/main...HEAD diff, and reran the relevant tests:
python -m pytest tests/channels/test_discord_channel.py -q→ 37 passed
From my side, this is clean and ready to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In , is assigned twice with the identical expression :
No code modifies or between the two assignments. The duplicate is a copy-paste leftover.
Change
Test plan