Closed
Conversation
4 tasks
… into feat/signal-integration
# Conflicts: # README.md # nanobot/agent/context.py # nanobot/agent/loop.py # nanobot/channels/manager.py # nanobot/cli/commands.py # nanobot/config/schema.py
Collaborator
|
Hi, thank you for your contribution! This PR has merge conflicts with the main branch that have remained unresolved for an extended period. To keep the repository healthy, we're closing stale PRs with conflicts. If you're still interested in this feature, please feel free to reopen with the conflicts resolved. We'd be happy to review a fresh PR! |
Collaborator
|
Because this issue has been inactive for a long time, I will close it. If there are any other problems, please feel free to open a new issue. |
super-david-ramos
pushed a commit
to super-david-ramos/nanobot-barnaby
that referenced
this pull request
Mar 17, 2026
…S#657) * fix: atomic claim prevents scheduled tasks from executing twice (HKUDS#138) Replace the two-phase getDueTasks() + deferred updateTaskAfterRun() with an atomic SQLite transaction (claimDueTasks) that advances next_run BEFORE dispatching tasks to the queue. This eliminates the race window where subsequent scheduler polls re-discover in-progress tasks. Key changes: - claimDueTasks(): SELECT + UPDATE in a single db.transaction(), so no poll can read stale next_run values. Once-tasks get next_run=NULL; recurring tasks get next_run advanced to the future. - computeNextRun(): anchors interval tasks to the scheduled time (not Date.now()) to prevent cumulative drift. Includes a while-loop to skip missed intervals and a guard against invalid interval values. - updateTaskAfterRun(): simplified to only record last_run/last_result since next_run is already handled by the claim. Closes HKUDS#138, HKUDS#211, HKUDS#300, HKUDS#578 Co-authored-by: @taslim (PR HKUDS#601) Co-authored-by: @baijunjie (Issue HKUDS#138) Co-authored-by: @Michaelliv (Issue HKUDS#300) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> * style: apply prettier formatting Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: track running task ID in GroupQueue to prevent duplicate execution (HKUDS#138) Previous commits implemented an "atomic claim" approach (claimDueTasks) that advanced next_run before execution. Per Gavriel's review, this solved the symptom at the wrong layer and introduced crash-recovery risks for once-tasks. This commit reverts claimDueTasks and instead fixes the actual bug: GroupQueue.enqueueTask() only checked pendingTasks for duplicates, but running tasks had already been shifted out. Adding runningTaskId to GroupState closes that gap with a 3-line fix at the correct layer. The computeNextRun() drift fix is retained, applied post-execution where it belongs. Closes HKUDS#138, HKUDS#211, HKUDS#300, HKUDS#578 Co-authored-by: @taslim (PR HKUDS#601) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * docs: add changelog entry for scheduler duplicate fix Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * docs: add contributors for scheduler race condition fix Co-Authored-By: Taslim <9999802+taslim@users.noreply.github.com> Co-Authored-By: BaiJunjie <7956480+baijunjie@users.noreply.github.com> Co-Authored-By: Michael <13676242+Michaelliv@users.noreply.github.com> Co-Authored-By: Kyle Zhike Chen <3477852+kk17@users.noreply.github.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: gavrielc <gabicohen22@yahoo.com> Co-authored-by: Taslim <9999802+taslim@users.noreply.github.com> Co-authored-by: BaiJunjie <7956480+baijunjie@users.noreply.github.com> Co-authored-by: Michael <13676242+Michaelliv@users.noreply.github.com> Co-authored-by: Kyle Zhike Chen <3477852+kk17@users.noreply.github.com>
steinnes
pushed a commit
to steinnes/nanobot
that referenced
this pull request
Apr 7, 2026
- Add SignalConfig, SignalDMConfig, SignalGroupConfig to schema - Add nanobot/channels/signal.py from PR HKUDS#601 Requires signal-cli daemon running in HTTP mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for Signal Messenger integration via the signal-cli daemon and updates the documentation and configuration to reflect this new capability. It also introduces new configuration classes and logic to enable and manage the Signal channel, and ensures user/session metadata is handled for improved context in agent prompts.
Signal Messenger Integration:
nanobot/channels/manager.py,nanobot/config/schema.py) [1] [2] [3]README.md) [1] [2] [3]Agent Context Improvements:
build_messagesmethod to accept and process ametadataparameter, allowing user/session information (such as sender name) to be included in the system prompt for better context. (nanobot/agent/context.py,nanobot/agent/loop.py) [1] [2] [3] [4] [5]