Skip to content

APC - Remove prompt attn with context and use existing implementation#1020

Merged
kzawora-intel merged 15 commits intohabana_mainfrom
adobrzyn/move_attn_with_context
Apr 11, 2025
Merged

APC - Remove prompt attn with context and use existing implementation#1020
kzawora-intel merged 15 commits intohabana_mainfrom
adobrzyn/move_attn_with_context

Conversation

@adobrzyn
Copy link
Copy Markdown

@adobrzyn adobrzyn commented Apr 7, 2025 •
edited by github-actions Bot
Loading

Twin PR: 135

APC will use our implementation of attn

@adobrzyn adobrzyn mentioned this pull request Apr 7, 2025
Merged
@adobrzyn
Copy link
Copy Markdown
Author

adobrzyn commented Apr 7, 2025

Please run tests

madamczyk-intel
madamczyk-intel requested changes Apr 8, 2025
View reviewed changes
Comment thread vllm/attention/backends/hpu_attn.py Outdated
@madamczyk-intel
Copy link
Copy Markdown

madamczyk-intel commented Apr 9, 2025

/run-gaudi-tests

2 similar comments
@adobrzyn
Copy link
Copy Markdown
Author

adobrzyn commented Apr 9, 2025

/run-gaudi-tests

@adobrzyn
Copy link
Copy Markdown
Author

adobrzyn commented Apr 10, 2025

/run-gaudi-tests

@adobrzyn
Copy link
Copy Markdown
Author

adobrzyn commented Apr 10, 2025

/run-gaudi-tests

@adobrzyn
Copy link
Copy Markdown
Author

adobrzyn commented Apr 10, 2025

/run-gaudi-tests

@adobrzyn
Copy link
Copy Markdown
Author

adobrzyn commented Apr 10, 2025

/run-gaudi-tests

@adobrzyn
Copy link
Copy Markdown
Author

adobrzyn commented Apr 10, 2025

/run-gaudi-tests

@adobrzyn
Copy link
Copy Markdown
Author

adobrzyn commented Apr 10, 2025

/run-gaudi-tests

@michalkuligowski
Copy link
Copy Markdown

michalkuligowski commented Apr 10, 2025

/run-gaudi-tests

@adobrzyn adobrzyn mentioned this pull request Apr 11, 2025
Merged
@kzawora-intel kzawora-intel merged commit 22ac593 into habana_main Apr 11, 2025
45 checks passed
@kzawora-intel kzawora-intel deleted the adobrzyn/move_attn_with_context branch April 11, 2025 13:01
michalkuligowski pushed a commit that referenced this pull request Apr 11, 2025
@adobrzyn
APC - Remove prompt attn with context and use existing implementation (…
035db32 
…#1059)

Same PR as [1020](#1020) but
for 1.21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@madamczyk-intel madamczyk-intel madamczyk-intel approved these changes

@kzawora-intel kzawora-intel Awaiting requested review from kzawora-intel kzawora-intel is a code owner

@michalkuligowski michalkuligowski Awaiting requested review from michalkuligowski michalkuligowski is a code owner

@mgawarkiewicz mgawarkiewicz Awaiting requested review from mgawarkiewicz

@vivekgoe vivekgoe Awaiting requested review from vivekgoe

@afierka-intel afierka-intel Awaiting requested review from afierka-intel afierka-intel is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adobrzyn @madamczyk-intel @michalkuligowski @kzawora-intel