fix prepare_cos_sin invoke in RotaryEmbedding#1035
Merged
michalkuligowski merged 4 commits intohabana_mainfrom Apr 17, 2025
Merged
fix prepare_cos_sin invoke in RotaryEmbedding#1035michalkuligowski merged 4 commits intohabana_mainfrom
michalkuligowski merged 4 commits intohabana_mainfrom
Conversation
Signed-off-by: zhouyu5 <yu.zhou@intel.com>
zhouyu5
requested review from
afierka-intel,
kzawora-intel,
madamczyk-intel,
mgawarkiewicz,
michalkuligowski and
vivekgoe
as code owners
Author
|
@michalkuligowski @madamczykhabana Could you have a review? |
michalkuligowski
approved these changes
Apr 9, 2025
|
/run-gaudi-tests |
yma11
approved these changes
Apr 10, 2025
|
/run-gaudi-tests |
|
/run-gaudi-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we use
if hasattr(self, "scaling_factors")to determine whether callprepare_cos_sin, however, some model's scaling factor inrope_scalinghas a slightly different name, which isscaling_factor(note: no ending 's'), in this case, it will failed to callprepare_cos_sin, which is not expected.This PR will help with the following class:
Llama3RotaryEmbeddingDynamicNTKScalingRotaryEmbeddingYaRNScalingRotaryEmbedding