Merged
Conversation
kdamaszk
force-pushed
the
dev/kdamaszke/flat_kv_cache
branch
from
9aae441 to
52e356a
Compare
kdamaszk
requested review from
afierka-intel,
kzawora-intel,
mgawarkiewicz,
michalkuligowski and
vivekgoe
as code owners
mswiniarsk
requested changes
Apr 17, 2025
kdamaszk
force-pushed
the
dev/kdamaszke/flat_kv_cache
branch
2 times, most recently
from
be02bd1 to
7c66881
Compare
michalkuligowski
approved these changes
Apr 17, 2025
|
/run-gaudi-tests |
1 similar comment
|
/run-gaudi-tests |
kdamaszk
force-pushed
the
dev/kdamaszke/flat_kv_cache
branch
2 times, most recently
from
d111a87 to
a7de3d2
Compare
Signed-off-by: Karol Damaszke <kdamaszke@habana.ai>
Signed-off-by: Karol Damaszke <kdamaszke@habana.ai>
Signed-off-by: Karol Damaszke <kdamaszke@habana.ai>
kdamaszk
force-pushed
the
dev/kdamaszke/flat_kv_cache
branch
from
a7de3d2 to
9737693
Compare
Signed-off-by: Karol Damaszke <kdamaszke@habana.ai>
kdamaszk
force-pushed
the
dev/kdamaszke/flat_kv_cache
branch
from
9737693 to
55c69c2
Compare
madamczyk-intel
requested changes
May 8, 2025
Signed-off-by: Karol Damaszke <kdamaszke@habana.ai>
Signed-off-by: Karol Damaszke <kdamaszke@habana.ai>
Author
|
Gain is visible also on prompts:
|
Signed-off-by: Karol Damaszke <kdamaszke@habana.ai>
Author
|
/run-gaudi-tests |
Signed-off-by: Karol Damaszke <kdamaszke@habana.ai>
Author
|
/run-gaudi-tests |
Signed-off-by: Karol Damaszke <kdamaszke@habana.ai>
Author
|
/run-gaudi-tests |
Author
|
/run-gaudi-tests |
Author
|
/run-gaudi-tests |
Author
|
/run-gaudi-tests |
Signed-off-by: Karol Damaszke <kdamaszke@habana.ai>
kdamaszk
requested review from
jikunshang,
mgawarkiewicz-intel and
xuechendi
as code owners
Author
|
/run-gaudi-tests |
kzawora-intel
approved these changes
May 20, 2025
madamczyk-intel
approved these changes
May 21, 2025
mswiniarsk
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change KV cache layout to (num_blocks * block_size, num_kv_heads, head_size). This will improve the performance as update will be done on 1D indices which will remove unnecessary transpose and memcopies due to low FCD.
Corresponding change: HabanaAI/vllm-hpu-extension#152
The influence of this feature could be observed on the below profilings, where
Transposeis no longer observed andindex_copykernels replaced the slower onesscatters:The gain from this feature is even better if we will use
split_qkv, as wholeindex_copyis hidden under MME activity: