add missing transpose in MultiHeadAttention#1218
Merged
michalkuligowski merged 2 commits intohabana_mainfrom May 7, 2025
Merged
add missing transpose in MultiHeadAttention#1218michalkuligowski merged 2 commits intohabana_mainfrom
michalkuligowski merged 2 commits intohabana_mainfrom
Conversation
Signed-off-by: zhouyu5 <yu.zhou@intel.com>
zhouyu5
requested review from
afierka-intel,
jikunshang,
kzawora-intel,
madamczyk-intel,
mgawarkiewicz-intel,
michalkuligowski,
mswiniarsk,
vivekgoe and
xuechendi
as code owners
michalkuligowski
approved these changes
May 7, 2025
|
/run-gaudi-tests |
xuechendi
pushed a commit
that referenced
this pull request
May 7, 2025
Since commit 09332dc, transpose in MultiHeadAttention was removed, guess it was by mistake, re-add it again. Signed-off-by: zhouyu5 <yu.zhou@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since commit 09332dc, transpose in MultiHeadAttention was removed, guess it was by mistake, re-add it again.