Embedding fix: warmup failure in embedding model#1510
Merged
michalkuligowski merged 3 commits intohabana_mainfrom Jul 9, 2025
Merged
Embedding fix: warmup failure in embedding model#1510michalkuligowski merged 3 commits intohabana_mainfrom
michalkuligowski merged 3 commits intohabana_mainfrom
Conversation
shepark
force-pushed
the
dev/shepark/fix_warmup_in_pooling
branch
2 times, most recently
from
a24d250 to
3518a32
Compare
libinta
requested review from
PatrykWo,
afierka-intel,
jikunshang,
kzawora-intel,
madamczyk-intel,
mgawarkiewicz-intel,
michalkuligowski,
mswiniarsk,
vivekgoe and
xuechendi
as code owners
libinta
changed the title
|
@shepark please fix pre-commit |
shepark
force-pushed
the
dev/shepark/fix_warmup_in_pooling
branch
2 times, most recently
from
126d667 to
7941fe3
Compare
Author
|
@kdamaszk I fixed previous pre-commit failure related to return type. |
shepark
force-pushed
the
dev/shepark/fix_warmup_in_pooling
branch
from
7941fe3 to
92e33d0
Compare
shepark
force-pushed
the
dev/shepark/fix_warmup_in_pooling
branch
from
92e33d0 to
2dd0233
Compare
kdamaszk
reviewed
Jul 7, 2025
|
/run-gaudi-tests |
michalkuligowski
left a comment
michalkuligowski
left a comment
There was a problem hiding this comment.
Triggered rerun for failing gsm8k_small_g3_tp1_fp8 Test Failed!
michalkuligowski
approved these changes
Jul 8, 2025
|
/run-gaudi-tests |
shepark
added a commit
that referenced
this pull request
Jul 9, 2025
Fix the failures at warmup stage in pooling mode -- due to. [rank0]: File "/wm/vllm-fork/vllm/worker/hpu_model_runner.py", line 2904, in warmup_model [rank0]: self.warmup_graphs( [rank0]: File "/wm/vllm-fork/vllm/worker/hpu_model_runner.py", line 2714, in warmup_graphs [rank0]: self.warmup_scenario(batch_size, [rank0]: File "/wm/vllm-fork/vllm/worker/hpu_model_runner.py", line 2561, in warmup_scenario [rank0]: inputs = self.prepare_model_input_align_worker( [rank0]: File "/wm/vllm-fork/vllm/worker/model_runner_base.py", line 233, in prepare_model_input_align_worker [rank0]: raise NotImplementedError [rank0]: NotImplementedError Co-authored-by: Libin Tang <litang@habana.ai>
shepark
added a commit
that referenced
this pull request
Jul 9, 2025
Fix the failures at warmup stage in pooling mode -- due to. [rank0]: File "/wm/vllm-fork/vllm/worker/hpu_model_runner.py", line 2904, in warmup_model [rank0]: self.warmup_graphs( [rank0]: File "/wm/vllm-fork/vllm/worker/hpu_model_runner.py", line 2714, in warmup_graphs [rank0]: self.warmup_scenario(batch_size, [rank0]: File "/wm/vllm-fork/vllm/worker/hpu_model_runner.py", line 2561, in warmup_scenario [rank0]: inputs = self.prepare_model_input_align_worker( [rank0]: File "/wm/vllm-fork/vllm/worker/model_runner_base.py", line 233, in prepare_model_input_align_worker [rank0]: raise NotImplementedError [rank0]: NotImplementedError Co-authored-by: Libin Tang <litang@habana.ai>
wpyszka
pushed a commit
that referenced
this pull request
Jul 22, 2025
Merge changes from habana_main for embedding fix #1510 ---- details ---- Fix the failures at warmup stage in pooling mode -- due to. [rank0]: File "/wm/vllm-fork/vllm/worker/hpu_model_runner.py", line 2904, in warmup_model [rank0]: self.warmup_graphs( [rank0]: File "/wm/vllm-fork/vllm/worker/hpu_model_runner.py", line 2714, in warmup_graphs [rank0]: self.warmup_scenario(batch_size, [rank0]: File "/wm/vllm-fork/vllm/worker/hpu_model_runner.py", line 2561, in warmup_scenario [rank0]: inputs = self.prepare_model_input_align_worker( [rank0]: File "/wm/vllm-fork/vllm/worker/model_runner_base.py", line 233, in prepare_model_input_align_worker [rank0]: raise NotImplementedError [rank0]: NotImplementedError Co-authored-by: Libin Tang <litang@habana.ai> Co-authored-by: Michał Kuligowski <mkuligowski@habana.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the failures at warmup stage in pooling mode
--
due to.
[rank0]: File "/wm/vllm-fork/vllm/worker/hpu_model_runner.py", line 2904, in warmup_model
[rank0]: self.warmup_graphs(
[rank0]: File "/wm/vllm-fork/vllm/worker/hpu_model_runner.py", line 2714, in warmup_graphs
[rank0]: self.warmup_scenario(batch_size,
[rank0]: File "/wm/vllm-fork/vllm/worker/hpu_model_runner.py", line 2561, in warmup_scenario
[rank0]: inputs = self.prepare_model_input_align_worker(
[rank0]: File "/wm/vllm-fork/vllm/worker/model_runner_base.py", line 233, in prepare_model_input_align_worker
[rank0]: raise NotImplementedError
[rank0]: NotImplementedError