[SW-234344] Fix 'RotaryEmbedding' object has no attribute 'sin'#1658
Merged
michalkuligowski merged 1 commit intohabana_mainfrom Jul 29, 2025
Merged
[SW-234344] Fix 'RotaryEmbedding' object has no attribute 'sin'#1658michalkuligowski merged 1 commit intohabana_mainfrom
michalkuligowski merged 1 commit intohabana_mainfrom
Conversation
Signed-off-by: Chendi.Xue <chendi.xue@intel.com>
xuechendi
requested review from
PatrykWo,
afierka-intel,
jikunshang,
kzawora-intel,
madamczyk-intel,
mgawarkiewicz-intel,
michalkuligowski,
mswiniarsk and
vivekgoe
as code owners
Author
|
/run-gaudi-tests |
3 tasks
michalkuligowski
approved these changes
Jul 25, 2025
wpyszka
pushed a commit
that referenced
this pull request
Jul 29, 2025
## Essential Elements of an Effective PR Description Checklist - [x] The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)". - [ ] The test plan, such as providing test command. - [ ] The test results, such as pasting the results comparison before and after, or e2e results ## Purpose port commit from #1658 for fixing SW-234344 for habana_main ## Test Plan ## Test Result <!--- pyml disable-next-line no-emphasis-as-heading --> Signed-off-by: Chendi.Xue <chendi.xue@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Essential Elements of an Effective PR Description Checklist
Purpose
Fix issue reported by https://jira.habana-labs.com/browse/SW-234344
Test Plan
Test Result