[bugfix] handle large bucket minimums correctly#235
Merged
kzawora-intel merged 5 commits intohabana_mainfrom Sep 4, 2024
Merged
[bugfix] handle large bucket minimums correctly#235kzawora-intel merged 5 commits intohabana_mainfrom
kzawora-intel merged 5 commits intohabana_mainfrom
Conversation
This reverts commit a40794b.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bugfix addresses incorrect lower boundary handling for bucketing
Previous behavior:
Min seq len dimension is set to 768, but buckets with seq_len=128-768 are present
Current behavior:
No bucket with seq_len < 768 is captured