Cleanup: Restore int64 sampling#35
Merged
kzawora-intel merged 1 commit intohabana_mainfrom May 22, 2024
Merged
Conversation
kzawora-intel
added a commit
that referenced
this pull request
May 23, 2024
yiliu30
pushed a commit
that referenced
this pull request
Aug 8, 2025
ripped from: #1606, fixes weird bucketing anomaly where bs=1 prefills would be padded to bs=2 and trigger a recompilation Signed-off-by: Konrad Zawora <kzawora@habana.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At some point during HPU re-integration, we changed sampler to operate on int32s. This change is no longer needed and we can roll it back to original state.