Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4190 +/- ##
=======================================
Coverage 96.54% 96.54%
=======================================
Files 27 27
Lines 2374 2374
Branches 966 966
=======================================
Hits 2292 2292
Misses 82 82 |
![hackerone-code[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ This pull request was sent to the PullRequest network.
Check the status or cancel PullRequest code review here.
There was a problem hiding this comment.
PullRequest Breakdown
Reviewable lines of change
+ 114
- 113
100% JavaScript (tests)Type of change
Feature - These changes are adding a new feature or improvement to existing code.
| 1 Message | |
|---|---|
| ✅ |
|
Zarthus
approved these changes
Oct 9, 2023
Contributor
Zarthus
left a comment
Zarthus
left a comment
There was a problem hiding this comment.
Changes seem harmless and LGTM, the CI seems happy too :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This pull request addresses an issue where the use of
ReactDOM.findDOMNodewas causing compatibility problems in certain scenarios. To resolve this, we have updated the code to usefindDOMNodedirectly.Changes Made:
ReactDOM.findDOMNodewithfindDOMNodethroughout the codebase.ReactDOM.findDOMNodemethod.