Merged
Conversation
![hackerone-code[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ This pull request was sent to the PullRequest network.
@dygy you can click here to see the review status or cancel the code review job.
Codecov Report
@@ Coverage Diff @@
## main #4324 +/- ##
==========================================
- Coverage 96.63% 96.63% -0.01%
==========================================
Files 27 27
Lines 2376 2375 -1
Branches 967 968 +1
==========================================
- Hits 2296 2295 -1
Misses 80 80
|
There was a problem hiding this comment.
Nice little refactor! Ship it!
/|~~~
///|
/////|
///////|
/////////|
\==========|===/
~~~~~~~~~~~~~~~~~~~~~
Reviewed with ❤️ by PullRequest
There was a problem hiding this comment.
this is a simple straightforward change fixing default className to empty string and looks good
Reviewed with ❤️ by PullRequest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix issue