🐛 Enable --keyboard-selected class to the YearPicker irrespective of the availability of selected prop#5670
Merged
martijnrusschen merged 1 commit intoHacker0x01:mainfrom Jun 2, 2025
Conversation
…is no selected date available Closes Hacker0x01#5669
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5670 +/- ##
==========================================
+ Coverage 97.11% 97.14% +0.03%
==========================================
Files 30 30
Lines 3363 3364 +1
Branches 1404 1404
==========================================
+ Hits 3266 3268 +2
+ Misses 97 96 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Linked issue: #5669
Problem
As I mentioned in the ticket, we're not applying
--keyboard-selectedclass over the active year of YearPicker, when there is no selected year set by default.Changes
I just removed the guard that prevent applying
--keyboard-selectedclass when theselectedprop is not available.Contribution checklist