Add dropdown keyboard accessibility#5728
Merged
martijnrusschen merged 6 commits intoHacker0x01:mainfrom Aug 15, 2025
Merged
Conversation
Member
|
Thanks, this looks interesting. Need to trigger the workflows to run the test suite. |
Member
|
Can you try rebasing with the latest changes on the main branch? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5728 +/- ##
==========================================
+ Coverage 97.19% 97.23% +0.03%
==========================================
Files 30 30
Lines 3391 3436 +45
Branches 1421 1440 +19
==========================================
+ Hits 3296 3341 +45
Misses 95 95 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Add tests for ArrowUp/ArrowDown navigation in month dropdown - Add tests for Escape key handling in month dropdown - Add tests for month wrapping (first->last, last->first) - Add tests for Enter/Escape/Arrow keys in year dropdown - Improves test coverage to 100% line coverage for both components - Resolves Codecov coverage gaps in dropdown keyboard accessibility 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Fix memory leak in month dropdown by clearing ref object on re-render - Add bounds checking for year navigation to prevent focusing non-existent elements - Use Record<number, Element> instead of array for more efficient ref management - Improve consistency between month and year dropdown implementations - Maintain 100% line coverage and improve branch coverage These improvements address code review feedback and enhance robustness. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue: #5609
Problem
The year and month dropdowns are not accessible via keyboard. The dropdown toggles cannot be focused, and the dropdown options cannot be navigated using arrow keys or selected with the Enter key.
Changes
Contribution checklist