Week classname support#5745
Merged
martijnrusschen merged 3 commits intoHacker0x01:mainfrom Aug 9, 2025
Merged
Conversation
Member
|
Can you look into the failing test? |
Member
|
Looks like a code formatting issue |
Contributor
Author
Hey @martijnrusschen, sure, I just pushed the fix. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5745 +/- ##
=======================================
Coverage 97.12% 97.13%
=======================================
Files 30 30
Lines 3374 3383 +9
Branches 1424 1429 +5
=======================================
+ Hits 3277 3286 +9
- Misses 95 97 +2
+ Partials 2 0 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Linked issue: #5744
Problem
See ticket.
Changes
I added a
weekClassNameprop to theWeekcomponent. I also added tests and a custom example.Screenshots
To reviewers
I would personally make the function signature
(date: Date) => string | undefinedto allow the consumers to returnundefineddeclaring that they do not want to add an extra class for this particular week.To follow the convention here I decided to keep it as
(date: Date) => stringto be inline with what all the other classname functions are doing. Slightly less elegant but the callers can still opt out by returning an empty string I guess.Contribution checklist