fix: improve DatePickerProps discriminated union type inference#6078
Merged
martijnrusschen merged 1 commit intomainfrom Dec 1, 2025
Merged
fix: improve DatePickerProps discriminated union type inference#6078martijnrusschen merged 1 commit intomainfrom
martijnrusschen merged 1 commit intomainfrom
Conversation
This fix addresses issue #5391 where TypeScript was not properly inferring the onChange callback type based on selectsRange and selectsMultiple props. The problem was that using 'never' as the discriminant type for optional properties didn't allow TypeScript to properly narrow the union type. Changes: - Changed selectsRange?: never to selectsRange?: false | undefined - Changed selectsMultiple?: never to selectsMultiple?: false | undefined - Updated test file to use correct type for selectsMultiple prop This allows TypeScript to correctly infer: - onChange receives Date | null when selectsRange is false/undefined - onChange receives [Date | null, Date | null] when selectsRange is true - onChange receives Date[] | null when selectsMultiple is true Fixes #5391
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6078 +/- ##
==========================================
+ Coverage 99.14% 99.22% +0.08%
==========================================
Files 30 30
Lines 3612 3612
Branches 1551 1547 -4
==========================================
+ Hits 3581 3584 +3
+ Misses 29 27 -2
+ Partials 2 1 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix addresses issue #5391 where TypeScript was not properly inferring the onChange callback type based on selectsRange and selectsMultiple props.
The problem was that using 'never' as the discriminant type for optional properties didn't allow TypeScript to properly narrow the union type.
Changes:
This allows TypeScript to correctly infer:
Fixes #5391