fix: support time selection with selectsRange for showTimeInput#6079
Merged
martijnrusschen merged 1 commit intomainfrom Dec 8, 2025
Merged
fix: support time selection with selectsRange for showTimeInput#6079martijnrusschen merged 1 commit intomainfrom
martijnrusschen merged 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6079 +/- ##
==========================================
+ Coverage 99.14% 99.23% +0.08%
==========================================
Files 30 30
Lines 3612 3644 +32
Branches 1548 1571 +23
==========================================
+ Hits 3581 3616 +35
+ Misses 29 27 -2
+ Partials 2 1 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5e81443 to
50392ce
Compare
Fixes #3673 and #4649 - When selectsRange is true with showTimeInput, render two time inputs (one for start date, one for end date) - Add modifyDateType parameter to handleTimeChange to explicitly specify which date to modify - Each time input independently updates its corresponding date - Add 7 new tests for showTimeInput with selectsRange functionality Changes: - src/index.tsx: Updated handleTimeChange to accept modifyDateType param - src/calendar.tsx: Updated renderInputTimeSection to render two inputs - src/test/datepicker_test.test.tsx: Added tests for new functionality
50392ce to
ac15422
Compare
This was referenced Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3673 and #4649
Changes: