test: add tests for openToDate with showTimeSelectOnly#6157
Merged
martijnrusschen merged 1 commit intomainfrom Dec 17, 2025
Merged
test: add tests for openToDate with showTimeSelectOnly#6157martijnrusschen merged 1 commit intomainfrom
martijnrusschen merged 1 commit intomainfrom
Conversation
Added tests to verify that openToDate can be used to specify the default date when showTimeSelectOnly is true and selected is null. This documents the existing behavior that addresses the feature request in #6032. Tests added: - openToDate as base date with showTimeSelectOnly and null selected - Current date fallback when neither selected nor openToDate provided - openToDate with showTimeInput and null selected Closes #6032 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6157 +/- ##
=======================================
Coverage 99.25% 99.25%
=======================================
Files 30 30
Lines 3783 3783
Branches 1627 1644 +17
=======================================
Hits 3755 3755
Misses 27 27
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds tests to document the existing behavior that
openToDatecan be used to specify the default date whenshowTimeSelectOnlyis true andselectedis null.Background
Issue #6032 requested a way to specify a default date when using
showTimeSelectOnlywith a null selected value. The user wanted to set a specific date (e.g., 2025-11-01) that would be used when a time is selected, instead of defaulting to the current date.Good news: This feature already exists! The
openToDateprop can be used for exactly this purpose.Example Usage
When the user selects a time (e.g., 09:06), the resulting date will be
2025-11-01 09:06:00instead of{today} 09:06:00.Tests Added
should use openToDate as the base date when selecting time with showTimeSelectOnly and selected is nullshould use current date when showTimeSelectOnly is true and neither selected nor openToDate is providedshould use openToDate for showTimeInput when selected is nullCloses #6032
🤖 Generated with Claude Code