fix: remove empty :global selector that breaks Lightning CSS#6165
Merged
martijnrusschen merged 1 commit intomainfrom Dec 18, 2025
Merged
fix: remove empty :global selector that breaks Lightning CSS#6165martijnrusschen merged 1 commit intomainfrom
martijnrusschen merged 1 commit intomainfrom
Conversation
Moved the sr-only comment from above the selector to inside it to prevent
Sass from generating an empty `:global {}` block in the CSS modules output.
This fixes build failures when using Rolldown Vite with Lightning CSS
minification, which throws "SyntaxError: Invalid empty selector".
Fixes #5989
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6165 +/- ##
=======================================
Coverage 99.26% 99.26%
=======================================
Files 30 30
Lines 3792 3792
Branches 1631 1648 +17
=======================================
Hits 3764 3764
Misses 27 27
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.react-datepicker__sr-onlyselector to inside it:global {}block in the CSS modules output when compilingdatepicker-cssmodules.scssRoot Cause
When the
/* sr-only utility class for accessibility */comment was placed as a standalone comment before the.react-datepicker__sr-onlyclass, Sass would wrap it in its own:global {}block in the CSS modules output:Since a comment doesn't count as actual CSS content, this resulted in an empty selector block that Lightning CSS rejects.
Test plan
yarn buildcompletes successfully:global {}blocks in generated CSS modules filesFixes #5989
🤖 Generated with Claude Code