fix: add base styles for month/year select dropdowns#6169
Merged
martijnrusschen merged 2 commits intomainfrom Dec 18, 2025
Merged
fix: add base styles for month/year select dropdowns#6169martijnrusschen merged 2 commits intomainfrom
martijnrusschen merged 2 commits intomainfrom
Conversation
Add styling for .react-datepicker__month-select, .react-datepicker__year-select, and .react-datepicker__month-year-select elements which were previously unstyled. The new styles use: - transparent background to inherit from parent (works with dark/light themes) - color: inherit to match the parent's text color - consistent border, border-radius, and font styling - focus-visible outline for accessibility This fixes issues where the native <select> elements would display with browser default styling, which looked bad especially in dark mode themes. Fixes #5786 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6169 +/- ##
==========================================
- Coverage 99.26% 99.18% -0.08%
==========================================
Files 30 30
Lines 3801 3801
Branches 1652 1652
==========================================
- Hits 3773 3770 -3
- Misses 27 29 +2
- Partials 1 2 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added styling for the month/year
<select>dropdown elements that were previously unstyled:.react-datepicker__month-select.react-datepicker__year-select.react-datepicker__month-year-selectProblem
When using
showMonthDropdown,showYearDropdown, orshowMonthYearDropdownwithdropdownMode="select", the native<select>elements had no styling and used browser defaults. This caused issues:Solution
Added base styles that:
transparentbackground to inherit from parent containercolor: inheritto match parent's text colorfocus-visibleoutline for accessibilitycursor: pointerfor better UXThis approach allows the dropdowns to work correctly with both light and dark themes by inheriting colors from their parent elements, rather than hardcoding specific color values.
Generated CSS
Test Plan
Fixes #5786
🤖 Generated with Claude Code