fix: clear selection when masked input is cleared on blur#6180
Merged
martijnrusschen merged 1 commit intomainfrom Dec 18, 2025
Merged
fix: clear selection when masked input is cleared on blur#6180martijnrusschen merged 1 commit intomainfrom
martijnrusschen merged 1 commit intomainfrom
Conversation
When using a controlled DatePicker with a mask library (like react-input-mask), clearing the input results in a mask pattern like "__/__/____" instead of an empty string. Previously, on blur the DatePicker would reset the input to the previously selected date because it treated the mask pattern as an unparseable date. This fix detects when the input value contains no alphanumeric characters (indicating a cleared mask pattern rather than an invalid date attempt) and clears the selection on blur instead of reverting to the previous date. This distinguishes between: - "__/__/____" (cleared mask) → clears the selection - "2025-02-45" (invalid date) → keeps previous selection (existing behavior) Fixes #5814 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6180 +/- ##
=======================================
Coverage 99.31% 99.31%
=======================================
Files 30 30
Lines 3801 3806 +5
Branches 1652 1654 +2
=======================================
+ Hits 3775 3780 +5
Misses 25 25
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
customInputwith mask library (likereact-input-mask) doesn't clear properly in React 18__/__/____instead of empty stringTechnical Details
The fix distinguishes between:
__/__/____(cleared mask) → clears the selection on blur2025-02-45(invalid date) → keeps previous selection (existing behavior preserved)This is done by checking if the input value contains any alphanumeric characters. If it doesn't (like a mask pattern with only underscores and slashes), we clear the selection.
Test plan
__/__/____)Fixes #5814
🤖 Generated with Claude Code