[Enhancement] Skip Enemy Cutscenes

[Eblo]

Some boss cutscene skips existed, but this expands the scope to include most bosses and mini-bosses in the game.

• Add new VB, VB_ENEMY_CUTSCENE_ACTION, that exists to be used within actor files. In most cases, it is a simple set to false to skip vanilla behavior. Other uses involve setting state information as part of the phase change cutscene skip, or a death cutscene skip. These uses were not covered by the existing cutscene hooks; some actors use their own timers and camera control for instance.
• Renamed boss skips to enemy skips, since the scope increased over what was there before
• Separated from story cutscene skips into new setting specifically for enemy cutscene skips

Build Artifacts

• 2ship-linux.zip
• 2ship-windows.zip
• 2ship-mac.zip

[Archez]

Left a little spam of comments lol, mainly trying to think about how to minimize impact to vanilla src (even if just whitesapcing related)

[Eblo]

Applied the 8 early return suggestions. The diff is a little cleaner now.

[garrettjoecox]

At a high level, this feels more invasive than I'd like on the source code for z_en_pametfrog, z_en_bigslime, and z_en_kaizoku.

If these actors aren't often in a scene, it might be worth trying to use ShouldActorUpdate, and conditionally overriding their actionFunc with a custom one that cuts out the undesired behavior before the update is run.

[Eblo]

The actors using VB_ENEMY_CUTSCENE_ACTION are indeed uncommon. I think what you're suggesting is feasible for the actor behavior changes, but camera behavior may not be so easy. I initially wanted to hook in at the lower level in the camera functions for exactly the reason of having to touch less of the source code as possible, but actor information is not accessible at that point. I'll see what I can do.

[Eblo]

If these actors aren't often in a scene, it might be worth trying to use ShouldActorUpdate, and conditionally overriding their actionFunc with a custom one that cuts out the undesired behavior before the update is run.

I pushed an update that does this just for EnPametfrog. Given how extensive the change in approach is, I wanted to do just one enemy to submit for consideration before doing all of them.

The footprint on z_en_pametfrog.c has now been eliminated, and in its place is SkipGekkoSnapperCutscenes.cpp. Much of the code there is duplicated actor functions, with references to camera controls removed. Since some of the camera code is nested in functions indirectly called by actionFuncs, this redundancy was unavoidable.

If this example is preferred over GameInteractor_Should calls, I can proceed with the other enemies. I think the ones you've named, including this one I've already done, would be the most extensive changes. The others should be simple to convert. Then the new VB can just be removed.

[Eblo]

After a discussion, I took Archez's suggestion to instead hook into the more common shared camera functions and use a static variable combined with actor lifecycle hooks to remove the need for ad-hoc modifications to individual actor source code. This flag is set to true when a relevant actor is initialized and false when the actor is destroyed. Considering that these cutscene-driven enemies don't share rooms with each other, that should be fine.

• VB_PLAYER_CUTSCENE_ACTION is used to stop actors from controlling/locking Link during cutscenes that are now skipped
• VB_SET_CAMERA_AT_EYE is used to prevent actors from controlling the camera for cutscenes that are now skipped
• VB_SET_CAMERA_FOV similar to the above, but only for Eyegore
• I also added some static variables to the enhancement file for player rotation. These are only used for the Fighter Pirate actor, which forces Link to face them during the now-skipped death cutscene. I could use ActorExtension if that's preferred, but that feels like a bit much overhead for something so brief and minor.

[Archez]

Loving the latest updates! The footprint has been significantly reduced which is nice.
Mainly had one bit of feedback below that I think should be worth considering.

[balloondude2]

Left a few minor nitpicks. It'd be nice to get some more QA on this.