Skip to content

Add ROM Selector#1203

Merged
Eblo merged 1 commit intoHarbourMasters:developfrom
mckinlee:multiple-roms-support
Oct 15, 2025
Merged

Add ROM Selector#1203
Eblo merged 1 commit intoHarbourMasters:developfrom
mckinlee:multiple-roms-support

Conversation

@mckinlee
Copy link
Contributor

@mckinlee mckinlee commented Jul 18, 2025

image In the event the user has multiple roms, this will detect it and allow them to choose which one rather than failing. Addresses #1184

Build Artifacts

@mckinlee
Copy link
Contributor Author

If someone can reproduce the issue, their assistance would be greatly appreciated. This was a quick write up to workaround it if need be, but I'd like to address the root cause. The reporter said they are on Windows 10 for additional context. As I'm not able to reproduce, that makes me assume it could be potentially related. If it is related, my assumption would be we need to revisit how we are ensuring the paths are valid.

@Eblo Eblo mentioned this pull request Aug 21, 2025
44 tasks
Copy link
Contributor

@Eblo Eblo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the issue in question, but I have no had luck in reproducing it. The behavior I see in 2.0.0 is that it will just prompt for and identify each ROM sequentially if you answer "No". The application certainly isn't doing "nothing".

I wonder if it was a path issue after all. While I cannot say whether this PR fixes that problem, I do like the option it presents as opposed to going through multiple ROMs sequentially.

@Eblo Eblo merged commit 4569ead into HarbourMasters:develop Oct 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants