Save play time, support timer display options#1213
Save play time, support timer display options#1213Eblo merged 2 commits intoHarbourMasters:developfrom
Conversation
|
I don't think the original timer was naive, but meant to be an RTA timer. I think we shouldn't replace it, but instead add this Play Time timer as an additional option. |
|
Fair enough. I think giving the display different options is a good idea. I'll return to this. |
|
Thank you for adding this, as with #1266 my intention here was for Speedruns specifically. The thought of just In Game Play-time was there but wasn't my priority at the time. |
|
This has been rebased against develop and is ready for re-review. |
garrettjoecox
left a comment
There was a problem hiding this comment.
Move lastTimeLog to ShipSaveContext, aside from that LGTM.
Clever use of timestamps to avoid incrementing a number every frame. Both that and the ability to have both RTA & gametime should be back-ported to SoH if you're feeling adventurous.
|
Moved the intermediate time tracking variable to |



Currently, save files have a timer display that shows the naive difference between the current time and the time when the file was created. This PR improves the time tracking so that it tracks the time actually spent between saves and not real time elapsed regardless of play.
2ship needs to update the tracked time in chunks with
SavingEnhancements_AdvancePlaytime(). This gets called when:Some logic for initializing and marking game completion were handled in the timer display element. I moved that to
SavingEnhancements.cpp.This necessitates and adds a save migration.
Build Artifacts