Skip to content

Save editor enhancements#1240

Merged
Eblo merged 5 commits intoHarbourMasters:developfrom
Eblo:save-editor-enhancements
Sep 3, 2025
Merged

Save editor enhancements#1240
Eblo merged 5 commits intoHarbourMasters:developfrom
Eblo:save-editor-enhancements

Conversation

@Eblo
Copy link
Contributor

@Eblo Eblo commented Aug 6, 2025

image image image

Build Artifacts

@Eblo Eblo mentioned this pull request Aug 21, 2025
44 tasks
Eblo added 3 commits August 24, 2025 22:59
Add tooltips to weekeventreg, owlActivation, and eventInf
Color code weekeventreg
Add toggle for Chateau Romani infinite magic
All shield to be removed
Copy link
Contributor

@balloondude2 balloondude2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple comments after comparing the TCRF weekEventReg flag designation against sPersistentCycleWeekEventRegs[] from z_sram_NES.c.

@Eblo Eblo force-pushed the save-editor-enhancements branch from 9a279c5 to bbe08cf Compare August 28, 2025 17:06
@Eblo
Copy link
Contributor Author

Eblo commented Aug 28, 2025

Pushed an update addressing feedback. Here's the color legend for the weekeventreg flag table:

image

Copy link
Contributor

@balloondude2 balloondude2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are looking really nice, just one last thing.

Co-authored-by: balloondude2 <55861555+balloondude2@users.noreply.github.com>
@Eblo Eblo merged commit 72b48cd into HarbourMasters:develop Sep 3, 2025
5 checks passed
@Eblo Eblo deleted the save-editor-enhancements branch September 3, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants