Merged
Conversation
Add tooltips to weekeventreg, owlActivation, and eventInf Color code weekeventreg Add toggle for Chateau Romani infinite magic All shield to be removed
balloondude2
requested changes
Aug 26, 2025
Contributor
balloondude2
left a comment
There was a problem hiding this comment.
Left a couple comments after comparing the TCRF weekEventReg flag designation against sPersistentCycleWeekEventRegs[] from z_sram_NES.c.
9a279c5 to
bbe08cf
Compare
Contributor
Author
balloondude2
requested changes
Aug 30, 2025
Contributor
balloondude2
left a comment
There was a problem hiding this comment.
These changes are looking really nice, just one last thing.
Co-authored-by: balloondude2 <55861555+balloondude2@users.noreply.github.com>
balloondude2
approved these changes
Aug 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Build Artifacts