[Rando] Restrict Ossan draw hook to Bomb Shop Owner#1316
Merged
balloondude2 merged 1 commit intoHarbourMasters:develop-mionfrom Nov 4, 2025
Merged
[Rando] Restrict Ossan draw hook to Bomb Shop Owner#1316balloondude2 merged 1 commit intoHarbourMasters:develop-mionfrom
balloondude2 merged 1 commit intoHarbourMasters:develop-mionfrom
Conversation
balloondude2
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The actor for the bomb shop owner curiously uses actor id
ACTOR_EN_OSSANeven though the actor isACTOR_EN_SOB1. The enhancement to draw the bomb shop owner's held item does not qualify based on which shop owner it is, leading to a bug where the trading post will draw the bomb shop owner's held item in the small stream of water. This corrects it to check that the actor is the bomb shop owner.Build Artifacts