Fix softlock from repeating Kafei's Mask check#1432
Merged
Eblo merged 1 commit intoHarbourMasters:develop-mionfrom Jan 4, 2026
Merged
Fix softlock from repeating Kafei's Mask check#1432Eblo merged 1 commit intoHarbourMasters:develop-mionfrom
Eblo merged 1 commit intoHarbourMasters:develop-mionfrom
Conversation
Eblo
added a commit
that referenced
this pull request
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Madame Aroma followed a hacky solution for handling notebook and no-notebook Get Item states, which results in softlocks on repeating her Mayor's Residence check in repeat cycles in rando. A better approach is to just queue the relevant notebook events from her final textbox in that interaction, which guarantees the player will be in a reading textbox state.
This will almost certainly clash with develop because develop changed some actor behavior flag stuff. Note to self to remember that when doing the next develop-mion->develop merge.
Build Artifacts