Various fixes for spelling and save editor time change lightning state#841
Merged
Archez merged 2 commits intoHarbourMasters:develop-satokofrom Nov 12, 2024
Merged
Conversation
Archez
commented
Nov 12, 2024
| ImGui::SeparatorText("Fixes"); | ||
| UIWidgets::CVarCheckbox( | ||
| "Fix Targetting Camera Snap", "gEnhancements.Camera.FixTargettingCameraSnap", | ||
| "Fix Targeting Camera Snap", "gEnhancements.Camera.FixTargettingCameraSnap", |
Contributor
Author
There was a problem hiding this comment.
Unfortunately this CVar also has the spelling mistake, but I'm leaving as is until a later release with a config migration.
Archez
force-pushed
the
various-fixes-spelling
branch
from
2c54e52 to
83caed0
Compare
garrettjoecox
approved these changes
Nov 12, 2024
Contributor
garrettjoecox
left a comment
garrettjoecox
left a comment
There was a problem hiding this comment.
I'll claim the 🥖 for a few of these
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes various fixes for spelling mistakes in comments, menu items, and an enum.
I'm also including a tiny tweak to how the save editor clears lightning when changing time. Before we set the state to
_LASTwhich meant that it lightning will stop after one more lightning bolt, but this is a random amount of time (sometimes 15+ seconds). Not sure why I originally used this state, but simply setting to_OFFis sufficient and avoids the lingering lightning bolt.Closes #829
Build Artifacts