Fix crashing with modern menu and UIWidgets with no tooltips#851
Merged
Archez merged 2 commits intoHarbourMasters:develop-satokofrom Nov 14, 2024
Merged
Conversation
Malkierian
approved these changes
Nov 13, 2024
garrettjoecox
approved these changes
Nov 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doing a couple things in here, mainly found a crash scenario with the modern menu if tooltips aren't provided. There is no current instance of a widget without a tooltip, just figured I get this in since I ran into it with some dummy toggles I was playing around with.
I also exposed the
save.isFirstCycleflag in the save editor in case we need it to help trouble shoot broken saves after the update (I think the saves should automatically fix themselves with the previous changes, but just in case).Build Artifacts