Proper fix for 2 handed idle animation

[garrettjoecox]

Upon further investigation, and thanks to the decomp @bug comment documenting the actual bug, the proper fix for 2 handed idle animation is more obvious. (and different than all of our attempts).

TLDR:

(
    (
        (commonType + FIDGET_SWORD_SWING != FIDGET_SWORD_SWING) &&
        (commonType + FIDGET_SWORD_SWING != FIDGET_ADJUST_SHIELD)
    ) ||
    (
        (player->rightHandType == PLAYER_MODELTYPE_RH_SHIELD) &&
        (
            (commonType + FIDGET_SWORD_SWING == FIDGET_ADJUST_SHIELD) ||
-            (Player_GetMeleeWeaponHeld2(player) != 0)
        )
    )
+   || (
+        (commonType + FIDGET_SWORD_SWING == FIDGET_SWORD_SWING) &&
+        (Player_GetMeleeWeaponHeld(player) != 0)
+    )
)

[serprex]

@Jepvid can you verify this addresses purpose of your original PRs?

[Jepvid]

Imo is a cleaner implementation rather than moving the cvar in a sense. havent tested if it actually idles like the other pr