Autodocs for datastore#25
Merged
tomkooij merged 19 commits intoHiSPARC:masterfrom Sep 9, 2017
Merged
Conversation
Make sure writer is a proper python package, so it can be imported by sphinx autodoc.
Make sure autodoc can import packages from datastore
Prevent ambiguous imports: writer is a package. The writer application is in the writer_app module of the writer package. The `main` function is named `writer`. from writer import writer_app writer_app.writer() writer/ __init__.py writer_app.py (modules)
Add hisparc_style.css Favicon Logo's
Docstrings in `__init__.py` and some additions.
tables.IsDescription classes do not work with :show-inheritance:
Member
Author
|
I pushed the current (7eaf413) version of the docs to http://docs.hisparc.nl/datastore/ |
1 task
Member
|
Added to docs.hisparc.nl: in HiSPARC/hisparc.github.io@8c72298 |
153957
approved these changes
Sep 9, 2017
Member
153957
left a comment
There was a problem hiding this comment.
Looks good to me, I think we can merge this and then improve documentation as we go. (and also merge HiSPARC/publicdb#185)
Member
Author
|
Merging. Cannot remove don't merge label on mobile... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sphinx autodocs for the datastore.
This is an attempt to document the datastore (scripts, raw datastore tables) using sphinx autodoc (docstrings). I already added/enhanced some docstrings. But the datastore can use some docs. That should be fairly easy now.
Caution: The writer was a script
writerin a folderwriterwith a main function calledwriter. To prevent ambiguous imports and to allow autodoc to work I change the writer into a package (analoguous to the wsgi package):So you can:
Perhaps
writer()should be renamedapplication()ormain()This will require some changes in the ansible config (publicdb repo).
I changed imports in both the writer and wsgi package. But I basically reverted back to the current imports (version running on frome now), so I don't expect problems (and there are unittests), but I will rerun the acceptance tests, which are semi-automated anyway.
ToDo:
gh-pagesdocs.hisparc.nl.